linux-kernel - Re: [PATCH 3/7] perf tools: Add parser for dynamic PMU events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1336388463.27020.3.camel@laptop>
Date:	Mon, 07 May 2012 13:01:03 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Robert Richter <robert.richter@....com>
Cc:	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Ingo Molnar <mingo@...nel.org>,
	Stephane Eranian <eranian@...gle.com>,
	Jiri Olsa <jolsa@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/7] perf tools: Add parser for dynamic PMU events

On Wed, 2012-05-02 at 20:26 +0200, Robert Richter wrote:
> This patch adds support for pmu specific event parsers by extending
> the pmu handler. The event syntax is the same as for tracepoints:
> 
>  <subsys>:<name>:<modifier> 

I really don't like this

> -          event_legacy_tracepoint sep_dc |
> +          event_legacy_generic sep_dc |

That 'legacy' in there is a good hint you shouldn't be using this.

Ideally I'd get rid of all legacy formats eventually, we really
shouldn't be adding new ones. 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/