linux-kernel - Re: [PATCH] x86 apic: only compile local function if used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120507131229.GF23858@gmail.com>
Date:	Mon, 7 May 2012 15:12:29 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Németh Márton <nm127@...email.hu>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	Yinghai Lu <yinghai@...nel.org>,
	Naga Chumbalkar <nagananda.chumbalkar@...com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86 apic: only compile local function if used


* Németh Márton <nm127@...email.hu> wrote:

> From: Márton Németh <nm127@...email.hu>
> 
> The local function io_apic_level_ack_pending() is only called from
> io_apic_level_ack_pending(). The later function is only compiled
> if CONFIG_GENERIC_PENDING_IRQ is defined. Use this define around
> io_apic_level_ack_pending() function as well.
> 
> This will remove the following warning message during compiling
> without CONFIG_GENERIC_PENDING_IRQ defined:
>  * arch/x86/kernel/apic/io_apic.c:382: warning: ‘io_apic_level_ack_pending’ defined but not used
> 
> Signed-off-by: Márton Németh <nm127@...email.hu>
> ---
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index e88300d..9b85009 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -379,6 +379,7 @@ static void __io_apic_modify(unsigned int apic, unsigned int reg, unsigned int v
>  	writel(value, &io_apic->data);
>  }
> 
> +#ifdef CONFIG_GENERIC_PENDING_IRQ
>  static bool io_apic_level_ack_pending(struct irq_cfg *cfg)
>  {
>  	struct irq_pin_list *entry;
> @@ -401,6 +402,7 @@ static bool io_apic_level_ack_pending(struct irq_cfg *cfg)
> 
>  	return false;
>  }
> +#endif
> 
>  union entry_union {
>  	struct { u32 w1, w2; };

it would be better/cleaner to just move this function into the 
already existing #ifdef CONFIG_GENERIC_PENDING_IRQ block.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/