linux-kernel - Re: [PATCH V1 4/4] regulator: tps62360: Provide settling time for voltage change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FA7DFF9.5010606@nvidia.com>
Date:	Mon, 7 May 2012 20:15:13 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"lrg@...com" <lrg@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V1 4/4] regulator: tps62360: Provide settling time for
 voltage change

On Monday 07 May 2012 07:52 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Mon, May 07, 2012 at 06:12:04PM +0530, Laxman Dewangan wrote:
>
>> Yaah, I should put the stylistic change at end..
>> I will send next patch for enabling cache and settling time.
>> Will keep discussion on stylistic changes and so will remove that
>> from this series.
> TBH I'd probably apply the style change if the regmap bit were using
> static inlines, though I'm not a big fan and wouldn't be happy with it
> in any consumer side code that I actively work on.

Actually I saw the multiple driver which uses set_bits()/clear_bits() 
and thought that this is good way of writing clean code and so developed 
multiple driver surrounding these apis.  Now seems it is easy for me to 
use these apis. May be it is my personal taste.

I will send the another patch making the function as static inline.

Thanks,
Laxman


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/