linux-kernel - Re: [PATCH][GIT PULL] ftrace/x86: Use asm/kprobes.h instead of linux/kprobes.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1336409637.14207.153.camel@gandalf.stny.rr.com>
Date:	Mon, 07 May 2012 12:53:57 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Subject: Re: [PATCH][GIT PULL] ftrace/x86: Use asm/kprobes.h instead of
 linux/kprobes.h

Bah, I forgot to update the subject (fixed)

Anyway, Ingo, can you pull this.

Thanks!

-- Steve


On Fri, 2012-05-04 at 09:49 -0400, Steven Rostedt wrote:
> Ingo,
> 
> This is based on top of tip/perf/core-3, and fixes the compile error
> that you saw with CONFIG_KPROBES disabled.
> 
> Please pull the latest tip/perf/core-4 tree, which can be found at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
> tip/perf/core-4
> 
> Head SHA1: 59a094c994a138049b41a44bc29cff9407d51c5b
> 
> 
> Steven Rostedt (1):
>       ftrace/x86: Use asm/kprobes.h instead of linux/kprobes.h
> 
> ----
>  arch/x86/kernel/ftrace.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> ---------------------------
> commit 59a094c994a138049b41a44bc29cff9407d51c5b
> Author: Steven Rostedt <srostedt@...hat.com>
> Date:   Fri May 4 09:26:16 2012 -0400
> 
>     ftrace/x86: Use asm/kprobes.h instead of linux/kprobes.h
>     
>     If CONFIG_KPROBES is not set, then linux/kprobes.h will not include
>     asm/kprobes.h needed by x86/ftrace.c for the BREAKPOINT macro.
>     
>     The x86/ftrace.c file should just include asm/kprobes.h as it does not
>     need the rest of kprobes.
>     
>     Reported-by: Ingo Molnar <mingo@...e.hu>
>     Cc: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
>     Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> 
> diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c
> index cf2d03e..4243e8b 100644
> --- a/arch/x86/kernel/ftrace.c
> +++ b/arch/x86/kernel/ftrace.c
> @@ -20,11 +20,11 @@
>  #include <linux/init.h>
>  #include <linux/list.h>
>  #include <linux/module.h>
> -#include <linux/kprobes.h>
>  
>  #include <trace/syscall.h>
>  
>  #include <asm/cacheflush.h>
> +#include <asm/kprobes.h>
>  #include <asm/ftrace.h>
>  #include <asm/nops.h>
>  
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/