linux-kernel - Re: Regression introduced by 6f381fa344911d5a234b13574433cf23036f9467 [[SCSI] scsi_lib: use correct DMA device in __scsi_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120507175039.GA6423@phenom.dumpdata.com>
Date:	Mon, 7 May 2012 13:50:39 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Lin Ming <ming.m.lin@...el.com>
Cc:	JBottomley@...allels.com, joerg@...a.gnuu.de,
	linux-kernel@...r.kernel.org
Subject: Re: Regression introduced by
 6f381fa344911d5a234b13574433cf23036f9467 [[SCSI] scsi_lib: use correct DMA
 device in __scsi_alloc_queue]

> > reverting above mentioned git commit fixes the issue.
> 
> Does Jame's below patch help?
> 
> http://www.spinics.net/lists/linux-scsi/msg59106.html

Yes.  please add Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
on the latter part of that patch:


diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 351dc0b..a3a056a 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -218,6 +218,9 @@ int scsi_add_host_with_dma(struct Scsi_Host *shost, struct device *dev,
 
 	if (!shost->shost_gendev.parent)
 		shost->shost_gendev.parent = dev ? dev : &platform_bus;
+	if (!dma_dev)
+		dma_dev = shost->shost_gendev.parent;
+
 	shost->dma_dev = dma_dev;
 
 	error = device_add(&shost->shost_gendev);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/