linux-kernel - Re: [PATCH v3 2/3] Staging: ipack: added support for the TEWS TPCI-200 carrier board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 08 May 2012 10:58:00 +0200
From:	Samuel Iglesias Gonsálvez 
	<siglesias@...lia.com>
To:	Manohar Vanga <manohar.vanga@...n.ch>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH v3 2/3] Staging: ipack: added support for the TEWS
 TPCI-200 carrier board

On Tue, 2012-05-08 at 10:15 +0200, Manohar Vanga wrote:
[...]
> 
> Check whether the function exists or you could have trouble :)
> If you already added a check when registering to make sure this is always non-NULL then
> ignore this. I would recommend wrapping this up in some function:
> 
>     void tpci_slot_remove(struct tpci_slot *slot)
>     {
>         if (slot->dev->driver->ops->remove)
>         	slot->dev->driver->ops->remove(slot->dev);
>     }
> 

OK, I agree that this is better and clearer. 

I am fixing some minor stuff I saw (one extra newline in ipack.h,
convert to "static" some functions, etc)

I hope this will increase the code quality and readability. 

Thanks a lot for your reviews,

Sam 

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)