linux-kernel - Re: [PATCH] regulator: tps62360: fix stylistic issue and optimize code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120508114655.GK15893@opensource.wolfsonmicro.com>
Date:	Tue, 8 May 2012 12:46:56 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	lrg@...com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: tps62360: fix stylistic issue and optimize
 code

On Tue, May 08, 2012 at 05:05:58PM +0530, Laxman Dewangan wrote:
> Fix multiple stylistic issue like:
> - The print message should be not break into multiple line.
> - line gap after variable declaration and statement.
> - checkpatch error.
> - some typo.

I've applied this but please in future always split changes into
separate patch rather than having a single jumbo change.  There's 
lots of different things here, things like the switch to using
gpio_request_one() should have been split out - this makes review
very much easier.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)