linux-kernel - Re: [PATCH bugfix v3.4] ALSA: hda - fix "silence after S3" regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5haa1i21bh.wl%tiwai@suse.de>
Date:	Tue, 08 May 2012 16:29:38 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Konstantin Khlebnikov <khlebnikov@...nvz.org>
Cc:	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	David Henningsson <david.henningsson@...onical.com>,
	Jaroslav Kysela <perex@...ex.cz>
Subject: Re: [PATCH bugfix v3.4] ALSA: hda - fix "silence after S3" regression

At Tue, 08 May 2012 17:38:45 +0400,
Konstantin Khlebnikov wrote:
> 
> Takashi Iwai wrote:
> > At Tue, 08 May 2012 17:08:10 +0400,
> > Konstantin Khlebnikov wrote:
> >>
> >> This fixes regression in shd-hda-codec after 785f857d1cb0856b612b46a0545b74aa2
> >> ("ALSA: hda - Set codec to D3 forcibly even if not used")
> >>
> >> hda_set_power_state() call must be explicitly protected against recursive
> >> snd_hda_power_up/down() calls, otherwise it accidentally switches device into
> >> D0 right before suspend. As result after resume sound device stays in D3 state
> >> and does not works because driver believes that the device is on already.
> >>
> >> Signed-off-by: Konstantin Khlebnikov<khlebnikov@...nvz.org>
> >
> > Hrm, does this really fix your problem?  The path is called only
> > during the suspend.  Then, in the resume path, the codec is all
> > powered up anyway.
> 
> This fixes my problem: during suspend hda_set_power_state() calls snd_hda_power_up()
> it set codec->power_on = 1 and switches device into D0. At S3 resume codec->power_on == 1
> but all devices actually in D3 state. As result on resume path device stays in D3,
> but after one power-save cycle all works again.

Ah, thanks, that explains a lot.

Then it'd be actually better to revert the commit instead of another
hack to paper over the nasty reincarnation.

The power-state change there shouldn't be involved with the whole
power-up sequence.  It should have been a simple "go-to-D3" sequence.
But this would need the assurance that the controller side is ready,
etc, and not too trivial to write with the current code base.

So, the right fix would be either implementing a straight
hda_set_power_state() code without any power-up sequence but only the
sanity check of the controller side, or fixing the original problem of
ALC269 differently, e.g. by always resuming immediately at the resume 
callback but immediately performing the power-saving work.

In either way, it's too late for 3.4 kernel.  And the original problem
is no critical issue in comparison with this regression.  So, a revert
would be the best thing we can do for now, IMO.

> > If the race between the leftover power-save work is really a culprit,
> > the fix would be just calling cancel_delayed_work_sync() before
> > that point...
> 
> Race was always there, my problem was caused by commit which mentioned above.
> 
> Whole this code is very racy, someone needs to fix it.

Yeah, I know.  I'll cook it up for 3.5 kernel.

thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/