linux-kernel - Re: [PATCH 5/6 v3] mfd: tps65910-irq: Add devicetree init support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120508162901.GD15893@opensource.wolfsonmicro.com>
Date:	Tue, 8 May 2012 17:29:02 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Rhyland Klein <rklein@...dia.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Liam Girdwood <lrg@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>
Subject: Re: [PATCH 5/6 v3] mfd: tps65910-irq: Add devicetree init support

On Tue, May 08, 2012 at 12:11:31PM -0700, Rhyland Klein wrote:

> Is this more what you would expect? If the dt code initialized the
> irq_base to 0 instead of -1 then this should also work.

> pdata->irq_base = irq_alloc_descs(-1, pdata->irq_base,
> 			tps65910->irq_num, -1);
> if (pdata->irq_base <= 0) {
> 	dev_err(tps65910->dev, "Failed to allocate irq descs: %d\n",
> 		pdata->irq_base);
> 	return pdata->irq_base;
> }

More like:

	if (pdata->irq_base)
		base = pdata->irq_base;
	else
		base = 0;
	pdata->irq_base = irq_alloc_descs(base, 0,

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)