linux-kernel - Re: [PATCH] mfd: da9052: fix of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 09 May 2012 01:00:12 +0800
From:	"Ying-Chun Liu (PaulLiu)" <paul.liu@...aro.org>
To:	Olof Johansson <olof@...om.net>
CC:	sameo@...ux.intel.com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: da9052: fix of_match_node() arguments

(2012年05月06日 07:02), Olof Johansson wrote:
> The driver calls of_match_node() with the arguments swapped.
> 
> Signed-off-by: Olof Johansson <olof@...om.net>
> ---
>  drivers/mfd/da9052-i2c.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c
> index d8abdb3..8410065 100644
> --- a/drivers/mfd/da9052-i2c.c
> +++ b/drivers/mfd/da9052-i2c.c
> @@ -104,7 +104,7 @@ static int __devinit da9052_i2c_probe(struct i2c_client *client,
>  		struct device_node *np = client->dev.of_node;
>  		const struct of_device_id *deviceid;
>  
> -		deviceid = of_match_node(np, dialog_dt_ids);
> +		deviceid = of_match_node(dialog_dt_ids, np);
>  		id = (const struct i2c_device_id *)deviceid->data;
>  	}
>  #endif

Tested-by: Ying-Chun Liu <paul.liu@...aro.org>


Sorry. I don't know how my code works and tested previously.
But your patch is definited correct.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/