linux-kernel - Re: [PATCH 02/23] x86, realmode: realmode.bin infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120508211112.GA12167@merkur.ravnborg.org>
Date:	Tue, 8 May 2012 23:11:13 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	"H. Peter Anvin" <h.peter.anvin@...el.com>
Cc:	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Jarkko Sakkinen <jarkko.sakkinen@...el.com>,
	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	Michal Marek <mmarek@...e.cz>,
	Joseph Cihula <joseph.cihula@...el.com>,
	Shane Wang <shane.wang@...el.com>
Subject: Re: [PATCH 02/23] x86, realmode: realmode.bin infrastructure

On Tue, May 08, 2012 at 01:15:15PM -0700, H. Peter Anvin wrote:
> On 05/08/2012 12:14 PM, H. Peter Anvin wrote:
> >>
> >> How much is needed to avoid this misuse of kernel-internal build rules?
> >> This was and is an ugly hack.
> >>
> > 
> > It is more or less the same as for arch/x86/boot and other things.  If
> > there are better ways to do it suggestions are very much appreciated.
> > 
> > However, it is a bit of a tricky bit because we need *some* of the bits
> > of the target compiler configuration and some not (this is the same as
> > arch/x86/boot etc.)  It is not "pure target" but it's also most
> > definitely not host.
> > 
> 
> Anyway... to answer your direct question: all of that would have been
> required anyway.  In therms of build rules the overall patchset is
> pretty much a lateral move from arch/x86/kernel/acpi/rm to
> arch/x86/realmode/rm.  That doesn't mean we couldn't do it
> better/centralize/etc; however, none of this is new and would be a
> separate change.

Agreed.
It just hurst my stummack big-time when KBUILD_CFLAGS are manupulated
in a "random" Makefile.
Last time we looked at this I failed to come up with something better.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/