linux-kernel - Re: [RFC/PATCH] PM / Hibernate : Add wait for disk detection if resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201205082328.54057.rjw@sisk.pl>
Date:	Tue, 8 May 2012 23:28:53 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Minho Ban <mhban@...sung.com>
Cc:	Pavel Machek <pavel@....cz>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC/PATCH] PM / Hibernate : Add wait for disk detection if resume_file is MAJOR:MINOR style

On Tuesday, May 08, 2012, Minho Ban wrote:
> On 05/08/2012 04:39 AM, Rafael J. Wysocki wrote:
> >> +	/* name_to_dev_t is ineffective if resume_file comes in major:minor
> >> +	 * format */
> >> +	if (isdigit(resume_file[0]) && resume_wait) {
> > 
> > The check here is too late.  It should be done before name_to_dev_t() is
> > used on resume_file for the first time.
> > 
> 
> Thanks for comment, I'll pull it up.
> 
> >> +		int partno;
> >> +		while (!get_gendisk(swsusp_resume_device, &partno))
> >> +			msleep(10);
> >> +	}
> >> +
> >>   Check_image:
> >>  	pr_debug("PM: Hibernation image partition %d:%d present\n",
> >>  		MAJOR(swsusp_resume_device), MINOR(swsusp_resume_device));
> > 
> > Besides, I'd like the documentation to be updated to reflect this change too.
> 
> Do you mean resumewait is needed to be updated in kernel-parameters.txt?

No, but it should be decumented what exactly is to be passed in
the resume= command line option (in kernel-parameters.txt).  Please do that
when you're at it.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/