linux-kernel - Re: [patch] xhci: testing sizeof xhci_doorbell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 7 May 2012 17:26:40 -0700
From:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
To:	girish verma <girish.gcet@...il.com>
Cc:	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [patch] xhci: testing sizeof xhci_doorbell_array 2 time

Hi Girish,

Although this is a pretty trivial change, can you please Cc the
maintainer of the driver (me, for the xHCI driver) next time?  Either
check the MAINTAINERS file, or run scripts/get_maintainer.pl.

In any case, I see no problem with this patch.  Greg's already taken it
anyway. :)

Thanks,
Sarah Sharp

On Sun, May 06, 2012 at 08:35:13PM +0530, girish verma wrote:
> Testing BUILD_BUG_ON xhci_doorbell_array structure 2 time, redundant statement
> 
> Signed-off-by: Girish Verma <girish.gcet@...il.com>
> 
>  ---
>  drivers/usb/host/xhci.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 36641a7..cfcf733 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -4090,7 +4090,6 @@ static int __init xhci_hcd_init(void)
>  	BUILD_BUG_ON(sizeof(struct xhci_intr_reg) != 8*32/8);
>  	/* xhci_run_regs has eight fields and embeds 128 xhci_intr_regs */
>  	BUILD_BUG_ON(sizeof(struct xhci_run_regs) != (8+8*128)*32/8);
> -	BUILD_BUG_ON(sizeof(struct xhci_doorbell_array) != 256*32/8);
>  	return 0;
>  unreg_pci:
>  	xhci_unregister_pci();
> --
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/