linux-kernel - Re: [ 153/167] [PATCH] x86, relocs: Remove an unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 May 2012 01:16:21 -0500
From:	Jonathan Nieder <jrnieder@...il.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, Kusanagi Kouichi <slash@...auone-net.jp>,
	"H. Peter Anvin" <hpa@...ux.intel.com>
Subject: Re: [ 153/167] [PATCH] x86, relocs: Remove an unused variable

Hi,

Ben Hutchings wrote:

> 3.2-stable review patch.  If anyone has any objections, please let me know.
[...]
> commit 7c77cda0fe742ed07622827ce80963bbeebd1e3f upstream.
>
> sh_symtab is set but not used.
>
> [ hpa: putting this in urgent because of the sheer harmlessness of the patch:
>   it quiets a build warning but does not change any generated code. ]
[...]
> --- a/arch/x86/boot/compressed/relocs.c
> +++ b/arch/x86/boot/compressed/relocs.c
> @@ -403,13 +403,11 @@ static void print_absolute_symbols(void)
>  	for (i = 0; i < ehdr.e_shnum; i++) {
>  		struct section *sec = &secs[i];
>  		char *sym_strtab;
> -		Elf32_Sym *sh_symtab;
>  		int j;
>  
>  		if (sec->shdr.sh_type != SHT_SYMTAB) {
>  			continue;
>  		}
> -		sh_symtab = sec->symtab;

This patch is a no-op.

The explanation in brackets above makes perfect sense in the context
of mainline, but I don't think this belongs in stable.

Thanks,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/