linux-kernel - Re: [PATCH] slab/mempolicy: always use local policy from interrupt context v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHGf_=pcLtNO9QyOUdiC4qOUNqEA4YQ-bvjrcDH4NzWEeffczw@mail.gmail.com>
Date:	Wed, 9 May 2012 04:03:43 -0400
From:	KOSAKI Motohiro <kosaki.motohiro@...il.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>, penberg@...nel.org,
	cl@...ux.com
Subject: Re: [PATCH] slab/mempolicy: always use local policy from interrupt
 context v3

>> > +       if (!in_interrupt() || !policy || policy->flags & MPOL_F_LOCAL)
>> >                return numa_node_id();
>>
>> I think your patch is correct. but I don't like interrupt context
>> dereference current task.
>> It would be nice if we only see current->mempolicy when !in_interrupt.
>>
>> But this doesn't mean NAK anyway.
>>
>>  Acked-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
>
> Sigh, this was acked by Christoph and KOSAKI when the logic is reversed
> and does the exact opposite of what's intended?

Ahhh, Good catch!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/