linux-kernel - [PATCH] 5fbd036b552f633abb394a319f7c62a5c86a9cd7 breaks PA-RISC boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1205082323020.21169@file.rdu.redhat.com>
Date:	Tue, 8 May 2012 23:30:05 -0400 (EDT)
From:	Mikulas Patocka <mpatocka@...hat.com>
To:	torvalds@...ux-foundation.org,
	Peter Zijlstra <peterz@...radead.org>
cc:	Stepan Moskovchenko <stepanm@...eaurora.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, Signed-off-by:;
Subject: [PATCH] 5fbd036b552f633abb394a319f7c62a5c86a9cd7 breaks PA-RISC boot



On Sat, 5 May 2012, Peter Zijlstra wrote:

> On Fri, 2012-05-04 at 23:26 -0400, Mikulas Patocka wrote:
> > Your patch 5fbd036b552f633abb394a319f7c62a5c86a9cd7 breaks PA-RISC boot. I 
> > have a dual-core PA-8800. With the patch applied, the kernel crashes with 
> > these messages. The timer structures are apparently corrupted, as the 
> > timer sees a negative amount of delayed cycles: 
> 
> You'll find:
> 
>   http://marc.info/?l=linux-parisc&m=133241790810604&w=2
> 
> will probably fix the issue.

I confirm that the patch fixes the problem.

So let's send it to Linus so that 3.4 will boot on PA-RISC.

Mikulas

---

The scheduler depends on receiving the CPU_STARTING notification, without
which we end up into a lot of trouble. So add the missing call to
notify_cpu_starting() in the bringup code.

Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@...ux.vnet.ibm.com>
Acked-by: Mikulas Patocka <mpatocka@...hat.com>
---

 arch/parisc/kernel/smp.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Index: linux-3.4-rc6-fast/arch/parisc/kernel/smp.c
===================================================================
--- linux-3.4-rc6-fast.orig/arch/parisc/kernel/smp.c	2012-05-09 04:54:35.000000000 +0200
+++ linux-3.4-rc6-fast/arch/parisc/kernel/smp.c	2012-05-09 04:55:24.000000000 +0200
@@ -295,8 +295,13 @@ smp_cpu_init(int cpunum)
 
 		printk(KERN_CRIT "CPU#%d already initialized!\n", cpunum);
 		machine_halt();
-	}  
+	}
+
+	notify_cpu_starting(cpunum);
+
+	ipi_call_lock();
 	set_cpu_online(cpunum, true);
+	ipi_call_unlock();
 
 	/* Initialise the idle task for this CPU */
 	atomic_inc(&init_mm.mm_count);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/