linux-kernel - Re: [PATCH v3 5/7] x86/tlb: remove comments for tlb_flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPa8GCDV5xs7gL0JJufL1EXvsdgW4EaMdVMxnFp7DFEnGnt_sw@mail.gmail.com>
Date:	Wed, 9 May 2012 18:22:36 +1000
From:	Nick Piggin <npiggin@...il.com>
To:	Alex Shi <alex.shi@...el.com>
Cc:	mgorman@...e.de, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, arnd@...db.de, rostedt@...dmis.org,
	fweisbec@...il.com, jeremy@...p.org, gregkh@...uxfoundation.org,
	glommer@...hat.com, riel@...hat.com, luto@....edu, avi@...hat.com,
	len.brown@...el.com, dhowells@...hat.com, fenghua.yu@...el.com,
	borislav.petkov@....com, yinghai@...nel.org, ak@...ux.intel.com,
	cpw@....com, steiner@....com, akpm@...ux-foundation.org,
	penberg@...nel.org, hughd@...gle.com, rientjes@...gle.com,
	kosaki.motohiro@...fujitsu.com, n-horiguchi@...jp.nec.com,
	paul.gortmaker@...driver.com, trenn@...e.de, tj@...nel.org,
	oleg@...hat.com, axboe@...nel.dk, a.p.zijlstra@...llo.nl,
	kamezawa.hiroyu@...fujitsu.com, viro@...iv.linux.org.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/7] x86/tlb: remove comments for tlb_flush_range
 implement suggestion

On 9 May 2012 00:03, Alex Shi <alex.shi@...el.com> wrote:
> Thanks to this comments that inspired me using invlpg to replace cr3
> rewrite.
> Now, it is time to remove from code to avoid reader confusing.

Nitpick, but this should just be folded into the patch which does the
invlpg conversion.

>
> Signed-off-by: Alex Shi <alex.shi@...el.com>
> ---
>  arch/x86/include/asm/tlbflush.h |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
> index ec30dfb..51f8b1c 100644
> --- a/arch/x86/include/asm/tlbflush.h
> +++ b/arch/x86/include/asm/tlbflush.h
> @@ -81,10 +81,6 @@ static inline void __flush_tlb_one(unsigned long addr)
>  *
>  * ..but the i386 has somewhat limited tlb flushing capabilities,
>  * and page-granular flushes are available only on i486 and up.
> - *
> - * x86-64 can only flush individual pages or full VMs. For a range flush
> - * we always do the full VM. Might be worth trying if for a small
> - * range a few INVLPGs in a row are a win.
>  */
>
>  #ifndef CONFIG_SMP
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/