linux-kernel - Re: [PATCH 02/23] x86, realmode: realmode.bin infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 09 May 2012 08:49:27 -0700
From:	"H. Peter Anvin" <h.peter.anvin@...el.com>
To:	Jarkko Sakkinen <jarkko.sakkinen@...el.com>
CC:	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	Michal Marek <mmarek@...e.cz>, Sam Ravnborg <sam@...nborg.org>,
	Joseph Cihula <joseph.cihula@...el.com>,
	Shane Wang <shane.wang@...el.com>, hpa@...ux.intel.com
Subject: Re: [PATCH 02/23] x86, realmode: realmode.bin infrastructure

On 05/08/2012 11:22 AM, Jarkko Sakkinen wrote:
> diff --git a/arch/x86/realmode/Makefile b/arch/x86/realmode/Makefile
> new file mode 100644
> index 0000000..f22a4f8
> --- /dev/null
> +++ b/arch/x86/realmode/Makefile
> @@ -0,0 +1,20 @@
> +#
> +# arch/x86/realmode/Makefile
> +#
> +# This file is subject to the terms and conditions of the GNU General Public
> +# License.  See the file "COPYING" in the main directory of this archive
> +# for more details.
> +#
> +#
> +
> +subdir- := rm
> +
> +obj-y += rmpiggy.o
> +
> +$(obj)/rmpiggy.o: $(obj)/rm/realmode.relocs $(obj)/rm/realmode.bin
> +
> +$(obj)/rm/realmode.bin: FORCE
> +	$(Q)$(MAKE) $(build)=$(obj)/rm $@
> +
> +$(obj)/rm/realmode.relocs: FORCE
> +	$(Q)$(MAKE) $(build)=$(obj)/rm $@

OK, this bit seems to cause serious problems.  Specifically, this
invokes the rm/ Makefile twice, and they end up doing two independent
builds in parallel, stepping on each other in the process.

Sam, Michal: do you have any suggestions for how to do the above better?

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/