linux-kernel - RE: [PATCH] staging: comedi: refactor sysfs files in comedi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ADE657CA350FB648AAC2C43247A983F0020698A1786A@AUSP01VMBX24.collaborationhost.net>
Date:	Wed, 9 May 2012 10:56:54 -0500
From:	H Hartley Sweeten <hartleys@...ionengravers.com>
To:	Linux Kernel <linux-kernel@...r.kernel.org>
CC:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"fmhess@...rs.sourceforge.net" <fmhess@...rs.sourceforge.net>,
	"abbotti@....co.uk" <abbotti@....co.uk>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: RE: [PATCH] staging: comedi: refactor sysfs files in comedi_fops.c

On Tuesday, May 08, 2012 7:17 PM, H Hartley Sweeten wrote:
>
> Refactor the sysfs attributes and functions to remove
> the need for the forward declarations and use the
> DEVICE_ATTR macro to define them.
>
> Instead of individually creating sysfs device attribute
> files, wrap them in an attribute_group and use the
> sysfs_create_group function to create them.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Ian Abbott <abbotti@....co.uk>
> Cc: Mori Hess <fmhess@...rs.sourceforge.net>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>
> ---

Oops... spotted a copy-paste error after I posted this.

<snip>

> @@ -2367,42 +2620,15 @@ int comedi_alloc_subdevice_minor(struct comedi_device *dev,
>  	if (!IS_ERR(csdev))
>  		s->class_dev = csdev;
>  	dev_set_drvdata(csdev, info);
> -	retval = device_create_file(csdev, &dev_attr_max_read_buffer_kb);
> +
> +	retval = sysfs_create_group(&csdev->kobj, &comedi_sysfs_files);
>  	if (retval) {
>  		printk(KERN_ERR
> -		       "comedi: "
> -		       "failed to create sysfs attribute file \"%s\".\n",
> -		       dev_attr_max_read_buffer_kb.attr.name);
> -		comedi_free_subdevice_minor(s);
> -		return retval;
> -	}
> -	retval = device_create_file(csdev, &dev_attr_read_buffer_kb);
> -	if (retval) {
> -		printk(KERN_ERR
> -		       "comedi: "
> -		       "failed to create sysfs attribute file \"%s\".\n",
> -		       dev_attr_read_buffer_kb.attr.name);
> -		comedi_free_subdevice_minor(s);
> -		return retval;
> -	}
> -	retval = device_create_file(csdev, &dev_attr_max_write_buffer_kb);
> -	if (retval) {
> -		printk(KERN_ERR
> -		       "comedi: "
> -		       "failed to create sysfs attribute file \"%s\".\n",
> -		       dev_attr_max_write_buffer_kb.attr.name);
> -		comedi_free_subdevice_minor(s);
> -		return retval;
> -	}
> -	retval = device_create_file(csdev, &dev_attr_write_buffer_kb);
> -	if (retval) {
> -		printk(KERN_ERR
> -		       "comedi: "
> -		       "failed to create sysfs attribute file \"%s\".\n",
> -		       dev_attr_write_buffer_kb.attr.name);
> -		comedi_free_subdevice_minor(s);
> +		       "comedi: failed to create sysfs attribute files\n");
> +		comedi_free_board_minor(i);

This should still be:

		comedi_free_subdevice_minor(s);

I'll fix it and re-post.

>  		return retval;
>  	}
> +
>  	return i;
>  }

Regards,
Hartley

 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/