linux-kernel - Re: [RFC][PATCH] printk: Add %pb to print bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120509173113.GD8135@gmail.com>
Date:	Wed, 9 May 2012 19:31:13 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Igor Mammedov <imammedo@...hat.com>, Jiang Liu <liuj97@...il.com>,
	linux-kernel@...r.kernel.org, pjt@...gle.com, tglx@...utronix.de,
	seto.hidetoshi@...fujitsu.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Joe Perches <joe@...ches.com>
Subject: Re: [RFC][PATCH] printk: Add %pb to print bitmaps


* Peter Zijlstra <peterz@...radead.org> wrote:

> On Wed, 2012-05-09 at 19:24 +0200, Ingo Molnar wrote:
>
> > I don't think that's a significant limitation, because it's 
> > fixed width anyway. So if this works then this would be a 
> > pretty good and simple to use solution.
> 
> Not quite following, there's nothing fixed width about 
> bitmap_scnlistprintf() output.

There's a maximum field length possible, and we should/could use 
that as padding.

Say for 8 bits, the worst-case is something like:

  1-2,4-5,7-8

right? The max is roughly len*3/2.

I see a problem there: for something larger like 256 it would 
lead to quite some padding ...

Well, we could just skip doing width for now - the ability to 
easily print bitmaps is very valuable in itself.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/