linux-kernel - Re: [PATCH 19/21] tile/PCI: Use pci_scan_root_bus instead pci_scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 May 2012 15:32:34 -0400
From:	Chris Metcalf <cmetcalf@...era.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Tony Luck <tony.luck@...el.com>,
	David Miller <davem@...emloft.net>, x86 <x86@...nel.org>,
	Dominik Brodowski <linux@...inikbrodowski.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arch@...r.kernel.org>
Subject: Re: [PATCH 19/21] tile/PCI: Use pci_scan_root_bus instead pci_scan_bus

On 5/7/2012 4:30 PM, Yinghai Lu wrote:
> It will update busn_res accordingly, so we get that for last_busno.
>
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> Cc: Chris Metcalf <cmetcalf@...era.com>
> ---
>  arch/tile/kernel/pci.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/arch/tile/kernel/pci.c b/arch/tile/kernel/pci.c
> index 7aa2743..4a951b87 100644
> --- a/arch/tile/kernel/pci.c
> +++ b/arch/tile/kernel/pci.c
> @@ -310,6 +310,7 @@ int __devinit pcibios_init(void)
>  		if (pci_scan_flags[i] == 0 && controllers[i].ops != NULL) {
>  			struct pci_controller *controller = &controllers[i];
>  			struct pci_bus *bus;
> +			LIST_HEAD(resources);
>  
>  			if (tile_init_irqs(i, controller)) {
>  				pr_err("PCI: Could not initialize IRQs\n");
> @@ -327,7 +328,9 @@ int __devinit pcibios_init(void)
>  			 * This is inlined in linux/pci.h and calls into
>  			 * pci_scan_bus_parented() in probe.c.
>  			 */
> -			bus = pci_scan_bus(0, controller->ops, controller);
> +			pci_add_resource(&resources, &ioport_resource);
> +			pci_add_resource(&resources, &iomem_resource);
> +			bus = pci_scan_root_bus(NULL, 0, controller->ops, controller, &resources);
>  			controller->root_bus = bus;
>  			controller->last_busno = bus->busn_res.end;
>  		}

We don't want ioport_resource on tilepro, since we don't support accessing
I/O port space.

With that one line removed:

Acked-by: Chris Metcalf <cmetcalf@...era.com>

Or, I can queue this change to take through the tile tree when the merge
window opens.  Which would you prefer?

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/