linux-kernel - Re: [PATCH 1/1] USB: serial: Whitespace and formatting to conform with checkpatch.sh script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120509214439.GA19041@kroah.com>
Date:	Wed, 9 May 2012 14:44:39 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Ben Minerds <puzzleduck@...il.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] USB: serial: Whitespace and formatting to conform
 with checkpatch.sh script

On Wed, May 09, 2012 at 11:11:50PM +1000, Ben Minerds wrote:
> Removed 19 errors and 53 warnings (space before tabs, spaces required
> around '?' ':' '=', space prohibited '(', trailing whitespace, not a
> function, and parentheses are not required).

That's nice, but please don't do this all in one patch.  Please do one
thing per patch (i.e. get rid of one type of warning or error per patch)

That way we can review it easier, and it can be applied easier.  As it
is, this patch doesn't apply to my usb-next branch due to other patches
in there already for this file that conflict with it.

Care to redo it and break it up and resend it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/