linux-kernel - Re: [PATCH] w1: Add 1-wire slave device driver for DS28E04-100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 May 2012 15:24:11 -0700
From:	Greg KH <greg@...ah.com>
To:	Markus Franke <markus.franke@...02.tu-chemnitz.de>
Cc:	Evgeniy Polyakov <zbr@...emap.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] w1: Add 1-wire slave device driver for DS28E04-100


A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, May 10, 2012 at 12:16:23AM +0200, Markus Franke wrote:
> Dear Greg,
> 
> the file "pio" is used for reading the current PIO state of the
> DS28E04-100.

Why is this a binary file?  That seems like it should not be, as a
binary sysfs file should be "pass-through" only.

> The "eeprom" file is for reading/writing the EEPROM memory of the same
> device.

That seems ok.

> As already mentioned before this is exactly the way how other w1 slave
> drivers are handling stuff like this.

Then those drivers are wrong as well, sorry :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/