linux-kernel - Re: [PATCH] spi/topcliff: use correct __devexit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120510002505.172243E08F4@localhost>
Date:	Wed, 09 May 2012 18:25:05 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	mathieu.poirier@...aro.org
Cc:	spi-devel-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, arnd@...db.de,
	mathieu.poirier@...aro.org
Subject: Re: [PATCH] spi/topcliff: use correct __devexit_p annotation

On Wed,  9 May 2012 16:35:23 -0600, mathieu.poirier@...aro.org wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> __devexit functions are discarded when CONFIG_HOTPLUG
> is not set, so the symbol needs to be referenced carefully.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>

Applied, thanks.

g.

> ---
>  drivers/spi/spi-topcliff-pch.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
> index ec47d3b..77c4562 100644
> --- a/drivers/spi/spi-topcliff-pch.c
> +++ b/drivers/spi/spi-topcliff-pch.c
> @@ -1779,7 +1779,7 @@ static struct pci_driver pch_spi_pcidev_driver = {
>  	.name = "pch_spi",
>  	.id_table = pch_spi_pcidev_id,
>  	.probe = pch_spi_probe,
> -	.remove = pch_spi_remove,
> +	.remove = __devexit_p(pch_spi_remove),
>  	.suspend = pch_spi_suspend,
>  	.resume = pch_spi_resume,
>  };
> -- 
> 1.7.5.4
> 

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/