linux-kernel - Re: [tip:sched/core] x86/numa: Check for nonsensical topologies on real hw as well

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1336651704.27020.100.camel@laptop>
Date:	Thu, 10 May 2012 14:08:24 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	mingo@...nel.org, hpa@...or.com, linux-kernel@...r.kernel.org,
	tj@...nel.org, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:sched/core] x86/numa: Check for nonsensical topologies on
 real hw as well

On Thu, 2012-05-10 at 13:49 +0200, Peter Zijlstra wrote:
> +static bool __cpuinit match_mc(struct cpuinfo_x86 *c, struct cpuinfo_x86 *o)
> +{
> +       if (!topology_sane(c->cpu_index, o->cpu_index, "mc"))
> +               return false;
> +
> +       if (c->phys_proc_id == cpu_data(i).phys_proc_id)
> +               return true;
> +
> +       return false;
> +} 

Argh, that has the very same problem.. it (and the same for the other
two match funcions).

Something like:

  if (c->phys_proc_id == cpu_data(i).phys_proc_id && topology_sane())

might do, since then we only verify the topology after we would
otherwise have already accepted it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/