linux-kernel - Re: [PATCH] mfd: lm3533-core: Fix calling regmap_update_bits() with mask and val arguments swapped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 May 2012 17:49:25 +0200
From:	Johan Hovold <jhovold@...il.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH] mfd: lm3533-core: Fix calling regmap_update_bits() with
 mask and val arguments swapped

On Thu, May 10, 2012 at 11:35:02PM +0800, Axel Lin wrote:
> Current code calls regmap_update_bits() with mask and val arguments swapped.
> Fix it.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Signed-off-by: Johan Hovold <jhovold@...il.com>

> ---

Ouch, I was sure I'd fixed that in the submitted v2.

/Johan


>  drivers/mfd/lm3533-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
> index 75f4b7f..4a006c2 100644
> --- a/drivers/mfd/lm3533-core.c
> +++ b/drivers/mfd/lm3533-core.c
> @@ -128,7 +128,7 @@ int lm3533_update(struct lm3533 *lm3533, u8 reg, u8 val, u8 mask)
>  
>  	dev_dbg(lm3533->dev, "update [%02x]: %02x/%02x\n", reg, val, mask);
>  
> -	ret = regmap_update_bits(lm3533->regmap, reg, val, mask);
> +	ret = regmap_update_bits(lm3533->regmap, reg, mask, val);
>  	if (ret < 0) {
>  		dev_err(lm3533->dev, "failed to update register %02x: %d\n",
>  								reg, ret);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/