lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 9 May 2012 23:58:56 -0300 (BRT)
From:	Thiago Rafel Becker <trbecker@...ecker.org>
To:	zwu.kernel@...il.com
cc:	linux-kernel@...r.kernel.org, axboe@...nel.dk,
	wuzhy@...ux.vnet.ibm.com, stefanha@...ux.vnet.ibm.com
Subject: Re: [PATCH] block: remove some unnecessary codes

You should also remove the if statement on line 511.

On Thu, 10 May 2012, zwu.kernel@...il.com wrote:

> From: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
>
> Signed-off-by: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
> ---
>  block/partition-generic.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/block/partition-generic.c b/block/partition-generic.c
> index 6df5d69..4c03880 100644
> --- a/block/partition-generic.c
> +++ b/block/partition-generic.c
> @@ -473,7 +473,6 @@ rescan:
>  	/* add partitions */
>  	for (p = 1; p < state->limit; p++) {
>  		sector_t size, from;
> -		struct partition_meta_info *info = NULL;
>
>  		size = state->parts[p].size;
>  		if (!size)
> @@ -509,7 +508,6 @@ rescan:
>  		}
>
>  		if (state->parts[p].has_info)
> -			info = &state->parts[p].info;
>  		part = add_partition(disk, p, from, size,
>  				     state->parts[p].flags,
>  				     &state->parts[p].info);
> --
> 1.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists