linux-kernel - Re: [PATCH] usb/dwc3: Fix the dwc3 dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120511075713.GA14284@arwen.pp.htv.fi>
Date:	Fri, 11 May 2012 10:57:16 +0300
From:	Felipe Balbi <balbi@...com>
To:	joseph daniel <josephdanielwalter@...il.com>
Cc:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb/dwc3: Fix the dwc3 dependency

On Fri, May 11, 2012 at 11:25:24AM +0530, joseph daniel wrote:
> The warning shown up when ran with randconfig,
> 
> warning: (USB_DWC3) selects USB_XHCI_PLATFORM which has unmet direct dependencies (USB_SUPPORT && USB_XHCI_HCD)
> 
> Signed-off-by: joseph daniel <josephdanielwalter@...il.com>
> ---
>  drivers/usb/dwc3/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index d8f741f..68271fa 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -1,6 +1,6 @@
>  config USB_DWC3
>  	tristate "DesignWare USB3 DRD Core Support"
> -	depends on (USB && USB_GADGET)
> +	depends on (USB && USB_SUPPORT && USB_XCHI_HCD && USB_GADGET)
					      ^^^^
					      typo

I would prefer the select to change:

select XHCI_PLATFORM if (USB_SUPPORT && USB_XHCI_HCD)

or something similar.

>  	select USB_OTG_UTILS
>  	select USB_GADGET_DUALSPEED
>  	select USB_GADGET_SUPERSPEED

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)