linux-kernel - Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+1xoqft4aM_qedn+TDx0z8creS_4mFf3S+4SUNjz0pe+=YHAg@mail.gmail.com>
Date:	Fri, 11 May 2012 12:35:07 +0200
From:	Sasha Levin <levinsasha928@...il.com>
To:	Kay Sievers <kay@...y.org>
Cc:	Greg Kroah-Hartmann <greg@...ah.com>,
	Yinghai Lu <yinghai@...nel.org>, Joe Perches <joe@...ches.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length
 record buffer

On Thu, May 10, 2012 at 4:30 AM, Kay Sievers <kay@...y.org> wrote:
> On Wed, 2012-05-09 at 16:06 -0700, Greg Kroah-Hartmann wrote:
>> On Wed, May 09, 2012 at 04:02:40PM -0700, Yinghai Lu wrote:
>> > On Wed, May 9, 2012 at 7:37 AM, Kay Sievers <kay@...y.org> wrote:
>> > >
>> > >> Changing printk semantics and trying to stabilize
>> > >> printk message content are bad ideas though.
>> > >
>> > > Again, nobody talks about content of here.
>> >
>> > printk_time=1 does not work anymore with this patch on serial console.
>>
>> Known issue, I think Kay is working on the solution for this right
>> now...
>
> Sure, and this seems to work for me.
>
> Thanks,
> Kay
>
>
> From: Kay Sievers <kay@...y.org>
> Subject: printk() - restore timestamp printing at console output
>
> The output of the timestamps got lost with the conversion of the
> kmsg buffer to records; restore the old behavior.
>
> Document, that CONFIG_PRINTK_TIME now only controls the output of
> the timestamps in the syslog() system call and on the console, and
> not the recording of the timestamps.
>
> Signed-off-by: Kay Sievers <kay@...y.org>
> ---

This has a small issue with the way timing is printed compared to how
it worked previously.

Consider the following case:

    printk("\n foo \n bar \n zoot")

Previously, you would see timing on each line of the print, but now
you see it only on the first.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/