lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 May 2012 20:53:13 +0800 From: Alex Shi <alex.shi@...el.com> To: Borislav Petkov <bp@...64.org> CC: rob@...dley.net, tglx@...utronix.de, mingo@...hat.com, hpa@...or.com, arnd@...db.de, rostedt@...dmis.org, fweisbec@...il.com, jeremy@...p.org, gregkh@...uxfoundation.org, riel@...hat.com, luto@....edu, avi@...hat.com, len.brown@...el.com, dhowells@...hat.com, fenghua.yu@...el.com, ak@...ux.intel.com, cpw@....com, steiner@....com, akpm@...ux-foundation.org, penberg@...nel.org, hughd@...gle.com, rientjes@...gle.com, kosaki.motohiro@...fujitsu.com, n-horiguchi@...jp.nec.com, paul.gortmaker@...driver.com, trenn@...e.de, tj@...nel.org, oleg@...hat.com, axboe@...nel.dk, a.p.zijlstra@...llo.nl, kamezawa.hiroyu@...fujitsu.com, viro@...iv.linux.org.uk, linux-kernel@...r.kernel.org Subject: Re: [PATCH v4 7/7] x86/tlb: add tlb_flushall_factor into sysfs for user testing/tuning On 05/11/2012 05:51 PM, Borislav Petkov wrote: > On Fri, May 11, 2012 at 08:52:09AM +0800, Alex Shi wrote: >>>> +#ifdef CONFIG_DEBUG_TLBFLUSH >> >>>> +static ssize_t __tlb_flushall_factor_store(const char *buf, >>>> + size_t count, int smt) >>>> +{ >>>> + short factor = 0; >>>> + >>>> + if (sscanf(buf, "%hd", &factor) != 1) >>>> + return -EINVAL; >>> >>> This means only single-digit factors, right? >> >> No, you can try '32' '16' etc. not a 'single-digit'. > > Ah, misread sscanf, nevermind. > >>> Why not use kstrtoul? >> >> any advantage of this? > > Well, sscanf uses simple_strto* and those miss overflow checks etc, see > 33ee3b2e2eb9b4b6c64dcf9ed66e2ac3124e748c for details. Thanks for reminder! > > Btw, there are other kstrto* functions which you could use to fit better > the argument type and size passed to tlb_flushall_factor. > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists