linux-kernel - Re: [PATCH] gpio: samsung: refactor gpiolib init for exynos4/5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 11 May 2012 13:00:55 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Kukjin Kim <kgene.kim@...sung.com>, Olof Johansson <olof@...om.net>
Cc:	kgene.kim@...sung.com, linus.walleij@...ricsson.com,
	sangsu4u.park@...sung.com, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] gpio: samsung: refactor gpiolib init for exynos4/5

On Tue, 10 Apr 2012 10:22:27 -0700, Kukjin Kim <kgene.kim@...sung.com> wrote:
> Olof Johansson wrote:
> > Only code move, no functional change.
> >
> > Main reason to do this was to get rid of the warnings:
> >
> > drivers/gpio/gpio-samsung.c: In function 'samsung_gpiolib_init':
> > drivers/gpio/gpio-samsung.c:2974:1: warning: label 'err_ioremap4' defined but not used [-Wunused-label]
> > drivers/gpio/gpio-samsung.c:2722:47: warning: unused variable 'gpio_base4' [-Wunused-variable]
> >
> > without adding more ifdef mess.
> >
> > I think this whole file would do well being coverted over to a platform
> > driver and moving most of the tables out to SoC code and/or device trees,
> > but since that changes init ordering it needs to be done with some care,
> > i.e. not at this time.
> >
> > Signed-off-by: Olof Johansson<olof@...om.net>
> 
> Looks ok to me :)
> 
> Acked-by: Kukjin Kim <kgene.kim@...sung.com>

Applied, thanks.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/