linux-kernel - Re: [ 018/167] [PATCH] brcm80211: smac: resume transmit fifo upon receiving frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 12 May 2012 00:42:03 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Arend van Spriel <arend@...adcom.com>
Cc:	stable@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	Francesco Saverio Schiavarelli <fschiava@...ero.it>,
	Pieter-Paul Giesberts <pieterpg@...adcom.com>,
	Brett Rudley <brudley@...adcom.com>,
	"John W. Linville" <linville@...driver.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [ 018/167] [PATCH] brcm80211: smac: resume transmit fifo upon
 receiving frames

On Wed, 2012-05-09 at 06:50 +0100, Ben Hutchings wrote:
> 3.2-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Arend van Spriel <arend@...adcom.com>
> 
> commit badc4f07622f0f7093a201638f45e85765f1b5e4 upstream.
> 
> There have been reports about not being able to use access-points
> on channel 12 and 13 or having connectivity issues when these channels
> were part of the selected regulatory domain. Upon switching to these
> channels the brcmsmac driver suspends the transmit dma fifos. This
> patch resumes them upon handing over the first received beacon to
> mac80211.
> 
> This patch is to be applied to the stable tree for kernel versions
> 3.2 and 3.3.

It looks like my earlier build test didn't include this driver, due to
'depends on BCMA=n'.  Unfortunately:

[...]
> +	/* unmute transmit */
> +	if (wlc->hw->suspended_fifos) {
> +		hdr = (struct ieee80211_hdr *)p->data;
> +		if (ieee80211_is_beacon(hdr->frame_control))
> +			brcms_b_mute(wlc->hw, false);
> +	}
[...]

brcms_b_mute() takes three arguments in 3.2.  Can you send me a patch to
fix this up in 3.2.y, or should I revert the change?

Ben.

-- 
Ben Hutchings
Experience is directly proportional to the value of equipment destroyed.
                                                         - Carolyn Scheppner

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)