linux-kernel - Re: [PATCH] kgbd: clear compilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120511062355.GX22134@mwanda>
Date:	Fri, 11 May 2012 09:23:55 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Thiago Rafael Becker <trbecker@...ecker.org>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, a.p.zijlstra@...llo.nl, jason.wessel@...driver.com,
	jan.kiszka@...mens.com, dhowells@...hat.com
Subject: Re: [PATCH] kgbd: clear compilation warning

On Fri, May 11, 2012 at 01:13:40AM -0300, Thiago Rafael Becker wrote:
> In the function kgbd_arch_set_breakpoint, the variable is only used
> if DEBUG_RODATA is configured. This clears the following compilation
> warning:
> 
> arch/x86/kernel/kgdb.c:749:7: warning: unused variable 'opc'
> 

This doesn't work.  Now there is a "warning: mixing declarations and
code" warning message for people who have CONFIG_DEBUG_RODATA
turned on.

I sent one of these yesterday where I did:

	if (!config_enabled(CONFIG_DEBUG_RODATA))
		return err;

But test it both ways and do a make arch/x86/kernel/kgdb.i and
make sure the code looks ok.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/