linux-kernel - Re: [PATCH v4 2/5] hwmon: exynos4: Move thermal sensor driver to driver/thermal directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120512153805.GB5769@ericsson.com>
Date:	Sat, 12 May 2012 08:38:05 -0700
From:	Guenter Roeck <guenter.roeck@...csson.com>
To:	Amit Daniel Kachhap <amit.kachhap@...aro.org>
CC:	"linux-pm@...ts.linux-foundation.org" 
	<linux-pm@...ts.linux-foundation.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"durgadoss.r@...el.com" <durgadoss.r@...el.com>,
	"lenb@...nel.org" <lenb@...nel.org>,
	"rui.zhang@...el.com" <rui.zhang@...el.com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linaro-dev@...ts.linaro.org" <linaro-dev@...ts.linaro.org>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	"khali@...ux-fr.org" <khali@...ux-fr.org>,
	"patches@...aro.org" <patches@...aro.org>
Subject: Re: [PATCH v4 2/5] hwmon: exynos4: Move thermal sensor driver to
 driver/thermal directory

On Sat, May 12, 2012 at 05:40:42AM -0400, Amit Daniel Kachhap wrote:
> This movement is needed because the hwmon entries and corresponding
> sysfs interface is a duplicate of utilities already provided by
> driver/thermal/thermal_sys.c. The goal is to place it in thermal folder
> and add necessary functions to use the in-kernel thermal interfaces.
> 
> CC: Guenter Roeck <guenter.roeck@...csson.com>
> Signed-off-by: Amit Daniel Kachhap <amit.kachhap@...aro.org>
> Signed-off-by: Donggeun Kim <dg77.kim@...sung.com>

Acked-by: Guenter Roeck <guenter.roeck@...csson.com>

Some suggestions, possibly for later cleanup.

> -
> -       data = kzalloc(sizeof(struct exynos4_tmu_data), GFP_KERNEL);

If you use devm_kzalloc, you won't have to free it.

[ ...]

> -       data->mem = request_mem_region(data->mem->start,
> -                       resource_size(data->mem), pdev->name);

Same here, with devm_request_mem_region.

[ ... ]

> -       data->base = ioremap(data->mem->start, resource_size(data->mem));

and devm_ioremap

[ ... ]

> -       ret = request_irq(data->irq, exynos4_tmu_irq,

and devm_request_irq

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/