linux-kernel - Re: [PATCH v2 1/1] HID: logitech: read all 32 bits of report type bitfield

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120512004410.GB2931@burratino>
Date:	Fri, 11 May 2012 19:44:10 -0500
From:	Jonathan Nieder <jrnieder@...il.com>
To:	Nestor Lopez Casado <nlopezcasad@...itech.com>
Cc:	Jiri Kosina <jkosina@...e.cz>,
	Benjamin Tissoires <benjamin.tissoires@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	hugo@...aldobarrera.com.ar, 671292@...s.debian.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v2 1/1] HID: logitech: read all 32 bits of report type
 bitfield

Nestor Lopez Casado wrote:

> From: Jonathan Nieder <jrnieder@...il.com>
>
> On big-endian systems (e.g., Apple PowerBook), trying to use a
> logitech wireless mouse with the Logitech Unifying Receiver does not
> work with v3.2 and later kernels.  The device doesn't show up in
> /dev/input.  Older kernels work fine.
>
> That is because the new hid-logitech-dj driver claims the device.  The
> device arrival notification appears:
>
>	20 00 41 02 00 00 00 00 00 00 00 00 00 00 00
>
> and we read the report_types bitfield (02 00 00 00) to find out what
> kind of device it is.  Unfortunately the driver only reads the first 8
> bits and treats that value as a 32-bit little-endian number, so on a
> powerpc the report type seems to be 0x02000000 and is not recognized.

Sigh, I took the wrong line in this example.  The above event is
"device list empty" and report_types is 0 as you'd expect.  The
example I meant to use:

		20 01 41 01 1a 10 04 00 00 00 00 00 00 00 00

	and we read the report_types bitfield (04 00 00 00) to find out what
	kind of device it is.  Unfortunately the driver only reads the first 8
	bits and treats that value as a 32-bit little-endian number, so on a
	powerpc the report type seems to be 0x04000000 and is not recognized.

Jiri, please amend the message if convenient, or I'm fine with leaving
it be if not.  Sorry for the nonsense.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/