linux-kernel - Re: [PATCH 6/7] scsi/megaraid: fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201205121302.21623.arnd@arndb.de>
Date:	Sat, 12 May 2012 13:02:21 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	adam radford <aradford@...il.com>
Cc:	mathieu.poirier@...aro.org, JBottomley@...allels.com,
	megaraidlinux@....com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] scsi/megaraid: fix sparse warnings

On Friday 11 May 2012, adam radford wrote:
> 
> On Fri, May 11, 2012 at 3:09 PM,  <mathieu.poirier@...aro.org> wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> >
> ...
> > diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> > index bfd87fa..234ad74 100644
> > --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> > +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> > @@ -51,55 +51,16 @@
> >  #include <scsi/scsi_device.h>
> >  #include <scsi/scsi_host.h>
> >
> > +#include "mega_common.h"
> 
> Do not include mega_common.h in the megaraid_sas driver.  It has
> nothing to do with this driver.  It is for the older Parallel SCSI
> megaraid drivers.

Ok. I think I first tried moving all declarations into mega_common.h
and then decided otherwise but forgot to remove that #include statement
again. Thanks for taking a look!

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/