linux-kernel - Re: [PATCH 1/2] staging: media: go7007: Adlink MPG24 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120513192148.GE16984@mwanda>
Date:	Sun, 13 May 2012 22:21:48 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Volokh Konstantin <volokh84@...il.com>
Cc:	my84@...ru, devel@...verdev.osuosl.org, hverkuil@...all.nl,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	mchehab@...radead.org, dhowells@...hat.com,
	justinmattock@...il.com, linux-media@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: media: go7007: Adlink MPG24 board

On Sun, May 13, 2012 at 10:52:41PM +0400, Volokh Konstantin wrote:
> This patch applies only for Adlink MPG24 board with go7007, all these changes were tested for continuous loading & restarting modes
> 
> This is minimal changes needed for start up go7007 to work correctly
>   in 3.4 branch
> 
> Changes:
>   - When go7007 reset device, i2c was not working (need rewrite GPIO5)
>   - As wis2804 has i2c_addr=0x00/*really*/, so Need set I2C_CLIENT_TEN flag for validity
>   - some main nonzero initialization, rewrites with kzalloc instead kmalloc
>   - STATUS_SHUTDOWN was placed in incorrect place, so if firmware wasn`t loaded, we
>     failed v4l2_device_unregister with kernel panic (OOPS)
>   - some new v4l2 style features as call_all(...s_stream...) for using subdev calls
> 

In some ways, yes, I can see that this seems like one thing "Make
go7007 work correctly", but really it would be better if each of
the bullet points was its own patch.

The changelogs should explain why you do something not what you do.
We can all see that kmalloc() was changed to kzalloc() but why? Is
their and information leak for example?  That might have security
implications and be good thing to know about.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/