[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4FB032BB.6060209@gmail.com>
Date: Mon, 14 May 2012 00:16:27 +0200
From: Vladimir 'φ-coder/phcoder' Serbinenko
<phcoder@...il.com>
To: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
Evgeniy Dushistov <dushistov@...l.ru>
Subject: Re: [PATCH] update i_blocks on UFS
On 13.05.2012 23:59, Evgeniy Dushistov wrote:
> On Sun, May 13, 2012 at 03:52:46PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>> UFS code dosn't update i_blocks which leads to the problems ranging from wrong
>> stat/du to long symlinks (as opposed to inline ones) being damaged. This is
>> a fix.
>>
>
> Yes, when quota support was removed, code that update statistic
> about usage of blocks also was removed. But why so big change to fix this?
> I found this problem some time ago and fixed it with code bellow,
> but may be I missed something?
>
Hm, I don't know why this code wasn't in my copy. Was it already
propagated to Linus' tree? When will it be? Which tree I should merge
from to get your latest fixes?
My code avoided counting metadata blocks (the ones holding the pointers
to actual blocks in indirect, double-indirect and triple-indirect
chains). I thought that i_blocks doesn't take into account the
metablocks but quick experiment with NetBSD image proved me wrong. So I
retract this patch altogether.
My UFS file size limit patch remains though.
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
Download attachment "signature.asc" of type "application/pgp-signature" (295 bytes)
Powered by blists - more mailing lists