| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 May 2012 08:03:16 +0900 From: Namjae Jeon <linkinjeon@...il.com> To: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> Cc: Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org, Amit Sahrawat <amit.sahrawat83@...il.com> Subject: Re: [PATCH 2/2] fat: use fat_msg_ratelimit in fat__get_entry. 2012/5/14, OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>: > Joe Perches <joe@...ches.com> writes: > >>> > Please don't split format strings. >>> > It's much harder to grep. >>> >>> Please fight with 80 columns guys before requesting it. >> >> That battle is long over. >> >> from Documentation/CodingStyle: >> >> Chapter 2: Breaking long lines and strings >> >> [] >> >> The limit on the length of lines is 80 columns and this is a strongly >> preferred limit. >> [] >> However, never break user-visible strings such as >> printk messages, because that breaks the ability to grep for them. > > Oh, I see. Namjae, can you adjust the patches to adjust for this? > I don't care either one, so you can add the following if you tweaked > patches. Hi. Ogawa. Okay, I will send you v2 patches for this. Thanks for your help. > > Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> > > Thanks. > -- > OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists