linux-kernel - Re: Linux-3.4-rc7 [build failure]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.1205131157290.22597@twin.jikos.cz>
Date:	Sun, 13 May 2012 12:13:15 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Paweł Sikora <pluto@...-linux.org>
Cc:	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: Linux-3.4-rc7 [build failure]

On Sun, 13 May 2012, Paweł Sikora wrote:

> Hi all,
> i see a build failure on modular kernel.
> 
> (...)
> Kernel: arch/x86/boot/bzImage is ready  (#15)
>   MODPOST 3501 modules
> ERROR: "handle_edge_irq" [drivers/gpio/gpio-pch.ko] undefined!
> ERROR: "irq_to_desc" [drivers/gpio/gpio-pch.ko] undefined!
> WARNING: modpost: Found 4 section mismatch(es).
> (...)

This is caused by

commit df9541a60af0985c3a756dc5f99b9253d2565a07
Author: Thomas Gleixner <tglx@...utronix.de>
Date:   Sat Apr 28 10:13:45 2012 +0200

    gpio: pch9: Use proper flow type handlers


as it adds

	__irq_set_handler_locked(d->irq, handle_edge_irq);

but handle_edge_irq() is not exported for modules (and inlined 
__irq_set_handler_locked() requires irq_to_desc() exported as well)

Thus the patch below fixes it; adding Thomas to CC to get his Ack for this 
first though.




From: Jiri Kosina <jkosina@...e.cz>
Subject: [PATCH] genirq: export handle_edge_irq() and irq_to_desc()

Export handle_edge_irq() and irq_to_desc() to modules to allow them to
do things such as

	__irq_set_handler_locked(...., handle_edge_irq);

This fixes

	ERROR: "handle_edge_irq" [drivers/gpio/gpio-pch.ko] undefined!
	ERROR: "irq_to_desc" [drivers/gpio/gpio-pch.ko] undefined!

when gpio-pch is being built as a module.

Signed-off-by: Jiri Kosina <jkosina@...e.cz>
---
 kernel/irq/chip.c    |    1 +
 kernel/irq/irqdesc.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 6080f6b..3914c1e 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -518,6 +518,7 @@ handle_edge_irq(unsigned int irq, struct irq_desc *desc)
 out_unlock:
 	raw_spin_unlock(&desc->lock);
 }
+EXPORT_SYMBOL(handle_edge_irq);
 
 #ifdef CONFIG_IRQ_EDGE_EOI_HANDLER
 /**
diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index d86e254..192a302 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -112,6 +112,7 @@ struct irq_desc *irq_to_desc(unsigned int irq)
 {
 	return radix_tree_lookup(&irq_desc_tree, irq);
 }
+EXPORT_SYMBOL(irq_to_desc);
 
 static void delete_irq_desc(unsigned int irq)
 {

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/