linux-kernel - Re: [PATCH] [RFC] UBI: Kill data type hint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 13 May 2012 17:28:38 +0200
From:	Richard Weinberger <richard@....at>
To:	Artem Bityutskiy <dedekind1@...il.com>
CC:	linux-mtd@...ts.infradead.org, tglx@...utronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RFC] UBI: Kill data type hint

Am 13.05.2012 16:41, schrieb Artem Bityutskiy:
> Hi Richard,
>
> On Fri, 2012-05-11 at 14:14 +0200, Richard Weinberger wrote:
>>   struct ubi_map_req {
>>          __s32 lnum;
>> -       __s8  dtype;
>> -       __s8  padding[3];
>> +       __s8  padding[4];
>>   } __packed;
>
>
> The "dtype" field is part of ABI, and merging it with padding is bad
> because padding holds "free" fields, which can be used in future. But
> "dtype" is not really free. I think it should stay here. You should put
> a comment explaining that it was used in the past for this and that, but
> now unused and ignored by UBI. Probably a date when we stopped using it
> would also be good.

Oh, it's ABI. Then I'll keep it and mark it as obsolete.

> May be it even deserves to be in a separate patches for this one and
> ubi_leb_change_req ?

Indeed.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/