linux-kernel - Re: Staging: comedi: Clean up patch series.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 14 May 2012 13:53:33 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Ravishankar Karkala Mallikarjunayya <ravishankarkm32@...il.com>
Cc:	wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: Staging: comedi: Clean up patch series.

On Fri, May 11, 2012 at 04:07:48PM +0530, Ravishankar Karkala Mallikarjunayya wrote:
> This patch series fixes some style issues in drivers/staging/comedi/drivers
> and fix some issues found by checkpatch.pl script.
> 
> Ravishankar Karkala Mallikarjunayya (25):
>       Staging: comedi: fix printk issue in usbduxfast.c
>       Staging: comedi: fix printk issues in usbduxfast.c
>       Staging: comedi: fix printk issue in usbduxfast.c
>       Staging: comedi: fix printk issue in usbduxfast.c
>       Staging: comedi: fix printk issue in usbduxfast.c
>       Staging: comedi: fix printk issue in usbduxfast.c
>       Staging: comedi: fix printk issues in usbduxfast.c
>       Staging: comedi: fix printk issue in rti800.c
>       Staging: comedi: fix printk issue in rti802.c
>       Staging: comedi: fix printk issue in s526.c
>       Staging: comedi: fix printk issue in s626.c
>       Staging: comedi: Checkpatch cleanups.
>       Staging: comedi: Checkpatch cleanups.
>       Staging: comedi: fix printk issue in serial2002.c
>       Staging: comedi: fix printk issue in unioxx5.c
>       Staging: comedi: fix printk issues in unioxx5.c
>       Staging: comedi: fix line over 80 character issue in unioxx5.c
>       Staging: comedi: Checkpatch cleanups.
>       Staging: comedi: Checkpatch cleanups.
>       Staging: comedi: Checkpatch cleanups.
>       Staging: comedi: fix printk issue in pcmmio.c.
>       Staging: comedi: fix printk issue in pcmad.c
>       Staging: comedi: fix printk issue in poc.c
>       Staging: comedi: fix printk issue in ni_pcimio.c
>       Staging: comedi: fix printk issue in ni_660x.c

You have lots of duplicated Subject: lines in here, that are not
descriptive at all.  You also do much the same exact thing in the same
exact files, yet you split it up into different patches for no apparent
reason at all.

Please rework this series to make one "logic" change per file, and make
better subject: lines that are understandable, I can't take any of these
as-is, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/