linux-kernel - Re: [PATCH] uio_pdrv_genirq: get irq through platform resource if not set otherwise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120514205627.GC6153@local>
Date:	Mon, 14 May 2012 22:56:28 +0200
From:	"Hans J. Koch" <hjk@...sjkoch.de>
To:	Benedikt Spranger <b.spranger@...utronix.de>
Cc:	hjk@...sjkoch.de, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, magnus.damm@...il.com
Subject: Re: [PATCH] uio_pdrv_genirq: get irq through platform resource if
 not set otherwise

On Mon, May 14, 2012 at 06:48:17PM +0200, Benedikt Spranger wrote:
> Platform devices are configured through platform resources. The interrupt
> in the driver uio_pdrv_genirq is instead configured through a side channel
> i.e. the platform data structure. Make it possible to use the generic
> configuration scheme via platform resource.

Looks alright to me.

> 
> Signed-off-by: Benedikt Spranger <b.spranger@...utronix.de>

Signed-off-by: "Hans J. Koch" <hjk@...sjkoch.de>

> ---
>  drivers/uio/uio_pdrv_genirq.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c
> index b98371d..42202cd 100644
> --- a/drivers/uio/uio_pdrv_genirq.c
> +++ b/drivers/uio/uio_pdrv_genirq.c
> @@ -146,6 +146,14 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev)
>  	priv->flags = 0; /* interrupt is enabled to begin with */
>  	priv->pdev = pdev;
>  
> +	if (!uioinfo->irq) {
> +		ret = platform_get_irq(pdev, 0);
> +		if (ret < 0) {
> +			dev_err(&pdev->dev, "failed to get IRQ\n");
> +			goto bad0;
> +		}
> +		uioinfo->irq = ret;
> +	}
>  	uiomem = &uioinfo->mem[0];
>  
>  	for (i = 0; i < pdev->num_resources; ++i) {
> -- 
> 1.7.9.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/