linux-kernel - Re: [Resend PATCH] tools/usb: fix a makefile bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 13 May 2012 21:20:51 -0700
From:	"'gregkh@...uxfoundation.org'" <gregkh@...uxfoundation.org>
To:	"Du, ChangbinX" <changbinx.du@...el.com>
Cc:	"'mina86@...a86.com'" <mina86@...a86.com>,
	"Fleming, Matt" <matt.fleming@...el.com>,
	"'balbi@...com'" <balbi@...com>, "'hpa@...or.com'" <hpa@...or.com>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	"'linux-usb@...r.kernel.org'" <linux-usb@...r.kernel.org>
Subject: Re: [Resend PATCH] tools/usb: fix a makefile bug

On Mon, May 14, 2012 at 03:17:42AM +0000, Du, ChangbinX wrote:
> I try to compile tools/usb foler, but got below error(gcc version
> 4.6.3):
> 	tools/usb/testusb.c:516: undefined reference to `pthread_create'
> 	tools/usb/testusb.c:541: undefined reference to `pthread_join'
> The reason is the makefile puts source files behind of compiler option
> "-l". For gcc(and clang), it reads compiler options in order from left
> to right. When compiler gets a source file, it starts parsing it and try
> to resolve all symbols invoked. If compiler can not resolve a symbol, it
> will read --remain-- options and try get a definition of the symbol. So,
> if we put source file behind of "-l" option, the specified library will
> not work.
> 
> Signed-off-by: Du Changbin <changbinx.du@...el.com>

I think that's a regression in your version of gcc, as 4.6.2 here works
just fine with no errors.

What distro's version of gcc are you using here?  What changed between
4.6.2 and 4.6.3 that would do this?

I just tried 4.5.3 and it worked just fine as well.

I'm thinking something might be messed up on your end here, and this
patch isn't really needed.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/