| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <87k40e1cco.fsf@sejong.aot.lge.com> Date: Tue, 15 May 2012 10:07:03 +0900 From: Namhyung Kim <namhyung.kim@....com> To: David Ahern <dsahern@...il.com> Cc: acme@...stprotocols.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH] perf-record: Create events initially disabled -- again Hi, On Mon, 14 May 2012 07:09:48 -0600, David Ahern wrote: > On 5/14/12 1:40 AM, Namhyung Kim wrote: >> A problem I see is that it'll break group handling again: >> >> $ ./perf stat -g sleep 1 >> >> Performance counter stats for 'sleep 1': >> >> <not counted> task-clock >> <not counted> context-switches >> <not counted> CPU-migrations >> <not counted> page-faults >> <not counted> cycles >> <not counted> stalled-cycles-frontend >> <not counted> stalled-cycles-backend >> <not counted> instructions >> <not counted> branches >> <not counted> branch-misses >> >> 1.000868932 seconds time elapsed >> >> So I suggest changing perf_target__none() check to a proper one >> (perf_target__no_cpu? - the name might be changed soon) for your >> purpose. >> > Something else is wrong then. I tested that command (saw your patch in > the history) and it worked for me. Also, this code path does not > affect perf-stat -- it touches perf-record and perf-test only. > Ah, right. But still wouldn't it be better changing the conditional rather than disabling it unconditionally? Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists