linux-kernel - Re: [PATCH 2/9 v3] dma: shdma: prepare for conversion to the shdma base library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1337055832.16185.5362.camel@vkoul-udesk3>
Date:	Tue, 15 May 2012 09:53:52 +0530
From:	Vinod Koul <vinod.koul@...ux.intel.com>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	linux-kernel@...r.kernel.org, Magnus Damm <magnus.damm@...il.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Paul Mundt <lethal@...ux-sh.org>, linux-sh@...r.kernel.org
Subject: Re: [PATCH 2/9 v3] dma: shdma: prepare for conversion to the shdma
 base library

On Wed, 2012-05-09 at 17:09 +0200, Guennadi Liakhovetski wrote:
> By placing an anonymous union at the top of struct sh_dmae_slave we can
> transparently prepare all device and client drivers for the upcoming
> shdma-base conversion.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@....de>
> ---
>  include/linux/sh_dma.h |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/sh_dma.h b/include/linux/sh_dma.h
> index 425450b..e081e8e 100644
> --- a/include/linux/sh_dma.h
> +++ b/include/linux/sh_dma.h
> @@ -10,12 +10,16 @@
>  #ifndef SH_DMA_H
>  #define SH_DMA_H
>  
> -#include <linux/list.h>
>  #include <linux/dmaengine.h>
> +#include <linux/list.h>
> +#include <linux/shdma-base.h>
>  
>  /* Used by slave DMA clients to request DMA to/from a specific peripheral */
>  struct sh_dmae_slave {
> -	unsigned int			slave_id; /* Set by the platform */
> +	union {
> +		unsigned int		slave_id; /* Set by the platform */
> +		struct shdma_slave	shdma_slave;
again, this should be move to dma_slave_config
> +	};
>  	struct device			*dma_dev; /* Set by the platform */
>  	const struct sh_dmae_slave_config	*config;  /* Set by the driver */
>  };


-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/