linux-kernel - Re: [PATCH 1/1] drivers/gpu/drm/i915: Fixed uninitialized variables (warnings).

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1337062773_35388@CP5-2952>
Date:	Tue, 15 May 2012 07:19:30 +0100
From:	Chris Wilson <chris@...is-wilson.co.uk>
To:	Raphael Carvalho <rsc.utroz@...il.com>, keithp@...thp.com,
	airlied@...ux.ie, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] drivers/gpu/drm/i915: Fixed uninitialized variables (warnings).

On Mon, 14 May 2012 20:57:07 -0300, Raphael Carvalho <rsc.utroz@...il.com> wrote:
> From 1e77059e8f3158fd4844e3f6a5466a063d2f407e Mon Sep 17 00:00:00 2001
> From: "Raphael S.Carvalho" <utroz@...coders.com>
> Date: Mon, 14 May 2012 20:19:24 -0300
> Subject: [PATCH 1/1]     drivers/gpu/drm/i915: Fixed uninitialized
>  variables (warnings).
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> As you see, this modifications were really very important because if the
> remain variable receives a value lower or equals than 0 from the args->size
> variable, indeed, a bad behavior could ocurrs.

Which is checked for before calling the function. Look harder at what
gcc is trying to tell you, the actual location of gcc's error is inside
an inlined function...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/