linux-kernel - Re: [PATCH] tracing: Check return value of tracing_dentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mx59zvj6.fsf@sejong.aot.lge.com>
Date:	Tue, 15 May 2012 17:41:01 +0900
From:	Namhyung Kim <namhyung.kim@....com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: Check return value of tracing_dentry_percpu()

Hi, Steve.

Can you have a look at this?

Thanks,
Namhyung

On Mon, 23 Apr 2012 10:11:57 +0900, Namhyung Kim wrote:
> If tracing_dentry_percpu() failed, tracing_init_debugfs_percpu()
> will try to create each cpu directories on debugfs' root directory
> as d_percpu is NULL.
>
> Signed-off-by: Namhyung Kim <namhyung.kim@....com>
> ---
>  kernel/trace/trace.c |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index ed7b5d1e12f4..54df9a672fd9 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -4367,6 +4367,9 @@ static void tracing_init_debugfs_percpu(long cpu)
>  	struct dentry *d_cpu;
>  	char cpu_dir[30]; /* 30 characters should be more than enough */
>  
> +	if (!d_percpu)
> +		return;
> +
>  	snprintf(cpu_dir, 30, "cpu%ld", cpu);
>  	d_cpu = debugfs_create_dir(cpu_dir, d_percpu);
>  	if (!d_cpu) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/