linux-kernel - Re: [PATCH 2/6] v4l/dvb: fix Kconfig dependencies on VIDEO_CAPTURE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FB23381.5020007@redhat.com>
Date:	Tue, 15 May 2012 07:44:17 -0300
From:	Mauro Carvalho Chehab <mchehab@...hat.com>
To:	mathieu.poirier@...aro.org
CC:	mchehab@...radead.org, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, arnd@...db.de
Subject: Re: [PATCH 2/6] v4l/dvb: fix Kconfig dependencies on VIDEO_CAPTURE_DRIVERS

Em 03-05-2012 19:22, mathieu.poirier@...aro.org escreveu:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Kconfig warns about unsatisfied dependencies of symbols that
> are directly selected.
> 
> Many capture drivers depend on DVB capture drivers, which
> are hidden behind the CONFIG_DVB_CAPTURE_DRIVERS setting.
> 
> The solution here is to enable DVB_CAPTURE_DRIVERS unconditionally
> when both DVB and VIDEO_CAPTURE_DRIVERS are enabled.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>
> ---
>  drivers/media/dvb/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/dvb/Kconfig b/drivers/media/dvb/Kconfig
> index f6e40b3..c617996 100644
> --- a/drivers/media/dvb/Kconfig
> +++ b/drivers/media/dvb/Kconfig
> @@ -29,7 +29,7 @@ config DVB_DYNAMIC_MINORS
>  	  If you are unsure about this, say N here.
>  
>  menuconfig DVB_CAPTURE_DRIVERS
> -	bool "DVB/ATSC adapters"
> +	bool "DVB/ATSC adapters" if !VIDEO_CAPTURE_DRIVERS
>  	depends on DVB_CORE
>  	default y
>  	---help---

No, this is not right. Users can select either DVB or V4L2 (or hybrid) 
devices independently.

If now a warning is happening, is because something changed Kconfig
behavior on some non-expected way.

Nack.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/