linux-kernel - [PATCH, resend] efivars: remove stray exports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <4FB262940200007800083CAC@nat28.tlf.novell.com>
Date:	Tue, 15 May 2012 13:05:08 +0100
From:	"Jan Beulich" <JBeulich@...e.com>
To:	<Matt_Domsch@...l.com>, <matt.fleming@...ux.intel.com>
Cc:	<linux-kernel@...r.kernel.org>
Subject: [PATCH, resend] efivars: remove stray exports

There's no in-tree consumer, and the way they are currently prototyped
it doesn't look like they're really usable from anywhere but the base
EFI implementation.

Signed-off-by: Jan Beulich <jbeulich@...e.com>

---
 drivers/firmware/efivars.c |   13 ++++++-------
 include/linux/efi.h        |    5 -----
 2 files changed, 6 insertions(+), 12 deletions(-)

--- 3.4-rc7/drivers/firmware/efivars.c
+++ 3.4-rc7-efivars/drivers/firmware/efivars.c
@@ -1039,7 +1039,7 @@ efivar_create_sysfs_entry(struct efivars
 	return 0;
 }
 
-static int
+static int __init
 create_efivars_bin_attributes(struct efivars *efivars)
 {
 	struct bin_attribute *attr;
@@ -1098,7 +1098,7 @@ out_free:
 	return error;
 }
 
-void unregister_efivars(struct efivars *efivars)
+static void unregister_efivars(struct efivars *efivars)
 {
 	struct efivar_entry *entry, *n;
 
@@ -1116,11 +1116,11 @@ void unregister_efivars(struct efivars *
 	kfree(efivars->del_var);
 	kset_unregister(efivars->kset);
 }
-EXPORT_SYMBOL_GPL(unregister_efivars);
 
-int register_efivars(struct efivars *efivars,
-		     const struct efivar_operations *ops,
-		     struct kobject *parent_kobj)
+static int __init
+register_efivars(struct efivars *efivars,
+		 const struct efivar_operations *ops,
+		 struct kobject *parent_kobj)
 {
 	efi_status_t status = EFI_NOT_FOUND;
 	efi_guid_t vendor_guid;
@@ -1192,7 +1192,6 @@ out:
 
 	return error;
 }
-EXPORT_SYMBOL_GPL(register_efivars);
 
 static struct efivars __efivars;
 static struct efivar_operations ops;
--- 3.4-rc7/include/linux/efi.h
+++ 3.4-rc7-efivars/include/linux/efi.h
@@ -655,11 +655,6 @@ struct efivars {
 	struct pstore_info efi_pstore_info;
 };
 
-int register_efivars(struct efivars *efivars,
-		     const struct efivar_operations *ops,
-		     struct kobject *parent_kobj);
-void unregister_efivars(struct efivars *efivars);
-
 #endif /* CONFIG_EFI_VARS */
 
 #endif /* _LINUX_EFI_H */



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/